Prune uploaded and pasted graphs correctly - #73
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/graphs/renderwhen pruningRoot Cause
Uploaded and pasted tabs kept their initial SVG and JSON objects in closure arguments. The prune handler requested a focused graph, but then immediately overwrote that response with the stale upload objects. The graph traversal also queued cyclic nodes indefinitely and only retained a selected node when it had an edge.
User Impact
Prune now operates on the graph visible in the selected tab—not the mounted Terraform project or an earlier rendering. Cyclic graphs terminate safely, isolated resources remain visible, and separate tabs cannot overwrite each other's source or options.
Validation
/tmp/blast-radius-plan-venv/bin/python -m pytest -q— 21 passed, 7 subtests passednode --test tests/frontend/*.test.js— passednode --check blastradius/server/static/js/blast-radius.jsgit diff --check main...HEADCompatibility
Default project graphs continue to use
/graph.svgand/graph.json. Uploaded and pasted graphs use the render API introduced for #45. Existing tab, search, selection, and prune controls retain their behavior and presentation.Fixes #5